Skip to content

VBENCH: rename parser.py to parser_vb.py #5979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from Jan 17, 2014
Merged

VBENCH: rename parser.py to parser_vb.py #5979

2 commits merged into from Jan 17, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jan 16, 2014

closes #5972

@dsm054, does this resolve the issue for you?

@dsm054
Copy link
Contributor

dsm054 commented Jan 16, 2014

Yep, seems to, and I went through a full test_perf.py to make sure that the parser_vb benchmarks were still being executed.

@ghost
Copy link
Author

ghost commented Jan 16, 2014

Worked for me too. Strange that it's not fully reproducible, I haven't had this
problem. Can you report versions? would like to understand where the difference lies.

ghost pushed a commit that referenced this pull request Jan 17, 2014
VBENCH: rename parser.py to parser_vb.py
@ghost ghost merged commit 8d8a44b into pandas-dev:master Jan 17, 2014
@ghost ghost deleted the PR_VB_parser_rename branch January 17, 2014 09:48
@TomAugspurger
Copy link
Contributor

@dsm054 are you on a Mac with homebrew python?

@dsm054
Copy link
Contributor

dsm054 commented Jan 20, 2014

@TomAugspurger: nope. Had the problem on both my notebook (ubuntu 13.04) and my work box (12.04).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vb_suite parser.py can shadow builtin parser module
2 participants