-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: groupby().any() returns true for groups with timedelta all NaT #59782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6a06a31
solved groupbyany bug
Petroncini 28b5450
added test for groupby
Petroncini ca40652
changed ops.py to correct mypy error
Petroncini 5a3e722
changed comments
Petroncini ab6bf95
simpler solution
Petroncini cbf77de
Merge branch 'main' into timedelta-null
Petroncini 2cb1ef2
changed order of mask=isna(values)
Petroncini b233e12
changed test
Petroncini 00329f3
Merge branch 'main' into timedelta-null
Petroncini 80e6225
changed test
Petroncini 8405f65
handling dtype in test
Petroncini 034a0e9
removed redundant comment, added issue number, updated doc
Petroncini f5c69e9
Update v3.0.0.rst
Petroncini 2d03fe6
Merge branch 'main' into timedelta-null
Petroncini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments in this test repeat the code verbatim. Can you remove them.
In addition, can you add a reference to the issue as the first line of this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added these changes.