Skip to content

REF: Minimize operations in recode_for_groupby #59618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2024
Merged

REF: Minimize operations in recode_for_groupby #59618

merged 1 commit into from
Aug 26, 2024

Conversation

mroeschke
Copy link
Member

  • .categories should already be unique, so no need to compute the operation on them
  • Don't pre-generate np.arange if it's not used

@mroeschke mroeschke added Refactor Internal refactoring of code Groupby Categorical Categorical Data Type labels Aug 26, 2024
@mroeschke mroeschke requested a review from rhshadrach as a code owner August 26, 2024 17:33
@mroeschke mroeschke added this to the 3.0 milestone Aug 26, 2024
rhshadrach
rhshadrach approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit 15e9e7a into pandas-dev:main Aug 26, 2024
53 checks passed
@rhshadrach
Copy link
Member

Thanks @mroeschke

@mroeschke mroeschke deleted the ref/recode_for_groupby branch August 26, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Groupby Refactor Internal refactoring of code
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @rhshadrach