Add doc for counting categorical dtype #59327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jahn96
commented
Jul 26, 2024
jahn96
commented
- closes BUG (?): dtype.value_counts() shows categorical multiple times #40735
- All code checks passed.
mroeschke
requested changes
Jul 26, 2024
|
|
||
| .. ipython:: python | ||
|
|
||
| df = pd.DataFrame({'a': [1], 'b': ['2'], 'c': [3], 'd': [3]}).astype({'a': 'category', 'c': 'category', 'd': 'category'}) |
There was a problem hiding this comment.
Can you put this in the docstring instead?
mroeschke
reviewed
Jul 27, 2024
| @@ -1178,3 +1180,9 @@ Use ``copy=True`` to prevent such a behaviour or simply don't reuse ``Categorica | |||
| This also happens in some cases when you supply a NumPy array instead of a ``Categorical``: | |||
| using an int array (e.g. ``np.array([1,2,3,4])``) will exhibit the same behavior, while using | |||
| a string array (e.g. ``np.array(["a","b","c","a"])``) will not. | |||
|
|
|||
| Counting CategoricalDtype | |||
There was a problem hiding this comment.
Could you undo the changes in this file?
There was a problem hiding this comment.
Looks like there's still changes in this file
There was a problem hiding this comment.
Ah sorry! Addressed here
mroeschke
reviewed
Jul 27, 2024
pandas/core/base.py
Outdated
| @@ -1049,6 +1049,34 @@ def value_counts( | |||
| 4.0 1 | |||
| NaN 1 | |||
| Name: count, dtype: int64 | |||
|
|
|||
| **categorial_dtypes** | |||
There was a problem hiding this comment.
Suggested change
| **categorial_dtypes** | |
| **Categorial Dtypes** |
mroeschke
approved these changes
Jul 30, 2024
|
Thanks @jahn96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.