CLN: Make io/data urls easier to monkey-patch #5817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about factoring out the function that generates the URL it self so that could be monkey patched. That way pandas can be resistant to more than just changes to the base URL. |
|
Certainly something to consider, but most of the functions are basically |
|
This looks like a good incremental change to me. merging. Don't think something more |
ghost
pushed a commit
that referenced
this pull request
Jan 3, 2014
CLN: Make io/data urls easier to monkey-patch
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful to make pandas more resilient to basic url changes
like that which happened with yahoo finance. That said, clearly
wholesale API changes won't be helped by this.
What do you all think, worth it to make this relatively trivial change?