CI: Remove ASAN job #57886
Merged
CI: Remove ASAN job #57886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think for now can just remove this until we can root cause it |
mroeschke
reviewed
Mar 18, 2024
| - name: "ASAN / UBSAN" | ||
| env_file: actions-311-sanitizers.yaml | ||
| pattern: "not slow and not network and not single_cpu and not skip_ubsan" | ||
| asan_options: "ASAN_OPTIONS=detect_leaks=0" |
There was a problem hiding this comment.
Could you remove these extra GHA args in this file/other files as well that are only used for this job too?
| @@ -68,14 +68,6 @@ jobs: | |||
| - name: "Pyarrow Nightly" | |||
| env_file: actions-311-pyarrownightly.yaml | |||
| pattern: "not slow and not network and not single_cpu" | |||
| - name: "ASAN / UBSAN" | |||
| env_file: actions-311-sanitizers.yaml | |||
There was a problem hiding this comment.
I guess we can remove this file too?
|
If you want to come back to this at a later time to debug and not completely remove some of the configurations, you could do: --- a/.github/workflows/unit-tests.yml
+++ b/.github/workflows/unit-tests.yml
@@ -160,7 +160,7 @@ jobs:
- name: Test (not single_cpu)
uses: ./.github/actions/run-tests
- if: ${{ matrix.name != 'Pypy' }}
+ if: ${{ matrix.name != 'Pypy' || matrix.name != 'ASAN / UBSAN'}}
with:
preload: ${{ matrix.preload }}
asan_options: ${{ matrix.asan_options }} |
mroeschke
approved these changes
Mar 19, 2024
|
Thanks @WillAyd |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 19, 2024
lithomas1
pushed a commit
that referenced
this pull request
Mar 19, 2024
Backport PR #57886: CI: Remove ASAN job Co-authored-by: William Ayd <will_ayd@innobi.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.