-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DEP: Deprecate CoW and no_silent_downcasting options #57872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1e81304
DEP: Deprecate CoW and no_silent_downcasting options
phofl 1aedba6
Fixup
phofl 9fb068f
Update
phofl 75cb981
Fixup
phofl e15c3bd
Merge branch 'main' into dep_cow_option
mroeschke 655db85
Fixup
phofl 46aa3c2
Update
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import importlib | ||
|
||
import pandas as pd | ||
import pandas._testing as tm | ||
|
||
|
||
def test_configs_deprecated(): | ||
# GH#57872 | ||
with tm.assert_produces_warning(FutureWarning, match="is deprecated"): | ||
pd.options.mode.copy_on_write = True | ||
|
||
with tm.assert_produces_warning(FutureWarning, match="is deprecated"): | ||
pd.options.future.no_silent_downcasting = True | ||
|
||
|
||
def test_env_variable(): | ||
# GH#57872 | ||
import os | ||
|
||
os.environ["PANDAS_COPY_ON_WRITE"] = "1" | ||
with tm.assert_produces_warning( | ||
FutureWarning, match="deprecated", check_stacklevel=False | ||
): | ||
importlib.reload(pd) | ||
os.environ.pop("PANDAS_COPY_ON_WRITE") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use
monkeypatch.setenv
? https://docs.pytest.org/en/7.1.x/reference/reference.html?highlight=monkeypatch#pytest.MonkeyPatch.setenv