Skip to content

CLN: Remove unused functions #57844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Mar 14, 2024

It's pretty hard to be 100% sure that these non-private functions are unused, but I'm pretty sure that they are not commonly used, if at all, after some searches in Google, GitHub, and pandas doc.

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These directories are documented as "private" so they are OK to remove.

@mroeschke mroeschke added this to the 3.0 milestone Mar 14, 2024
@mroeschke mroeschke merged commit d831326 into pandas-dev:main Mar 14, 2024
@mroeschke
Copy link
Member

Keep them coming! @tqa236

@tqa236
Copy link
Contributor Author

tqa236 commented Mar 14, 2024

@mroeschke thanks! I'm combing through vulture to see what can be removed. May I know where the documentation about the private directories is, please? It'll surely help me decide if a report is a true or false positive

@tqa236 tqa236 deleted the remove-unused-function branch March 14, 2024 20:55
@mroeschke
Copy link
Member

May I know where the documentation about the private directories is, please?

https://pandas.pydata.org/docs/reference/index.html#api-reference

@tqa236
Copy link
Contributor Author

tqa236 commented Mar 15, 2024

Thank you!

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants