Skip to content

ENH: Adds ability to store tooltips as title attribute through pandas styler #56981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Delengowski
Copy link
Contributor

@Delengowski Delengowski requested a review from attack68 as a code owner January 20, 2024 16:17
@Delengowski
Copy link
Contributor Author

@attack68

@Delengowski
Copy link
Contributor Author

Delengowski commented Jan 20, 2024

When I run ruff locally, on the files I changed, there are no changes made.

edit: Too fast to comment.

@attack68 attack68 added the Styler conditional formatting using DataFrame.style label Jan 20, 2024
@Delengowski
Copy link
Contributor Author

Getting back to this tonight, will address all comments.

@Delengowski Delengowski requested a review from WillAyd as a code owner January 28, 2024 00:53
Copy link
Contributor

@attack68 attack68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, much happier after the removal of regex and sticking with existing pattern.

couple of quick suggestions, and it looks like a merge gone wrong somewhere, there are a few dangling unrelated file changes. Probably just needs final merge to master, then I will look to approve,.

Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
@Delengowski
Copy link
Contributor Author

Do I have to worry about that Numpy failure?

@attack68
Copy link
Contributor

attack68 commented Feb 5, 2024

No I dont think so it looks unrelated. And if on the off chance it is not it is probably worth fixing in a follow up PR.

Copy link
Contributor

@attack68 attack68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you still have some floating black issues that add commas in random files. Perhaps a re-merge necessary as one final thing.

@rhshadrach @mroeschke you OK to merge this is?

@Delengowski
Copy link
Contributor Author

If I merge main one more time, am I good?

@attack68
Copy link
Contributor

Tests are passing and dangling 'comma' changes have gone. I think this is ready now.

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merge when ready @rhshadrach

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, lgtm!

@rhshadrach rhshadrach added this to the 3.0 milestone Feb 15, 2024
@rhshadrach rhshadrach merged commit 06a7251 into pandas-dev:main Feb 15, 2024
@rhshadrach
Copy link
Member

Thanks @Delengowski!

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add alternative html for Styler tooltips
4 participants