TST/CLN: Remove more seldom used fixtures #56625
Conversation
This reverts commit e4f81bb.
mroeschke
added
the
Testing
|
|
||
|
|
||
| @pytest.fixture | ||
| def filepath_or_buffer(filepath_or_buffer_id, tmp_path): |
There was a problem hiding this comment.
I am surprised this is only used in one place - do we not have something similar elsewhere already?
There was a problem hiding this comment.
Fixture-wise I don't think so. But I think I've seen similar testing over string-path, file-obj-path, buffer in other tests. I can try to track those down and fixture-ize in a followup
| @@ -2668,7 +2422,243 @@ def test_allow_exact_matches_and_tolerance( | |||
| tolerance=Timedelta("100ms"), | |||
| allow_exact_matches=False, | |||
| ) | |||
| expected = allow_exact_matches_and_tolerance | |||
| df = pd.DataFrame( | |||
There was a problem hiding this comment.
Totally separate from this PR but would be nice to have test data that does not span 200 lines of code
| @@ -238,20 +229,23 @@ def test_sub(date, offset_box, offset2): | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
| "offset_box, offset1", | |||
| "offset_box, offset1, dt", | |||
There was a problem hiding this comment.
Maybe dt should just be a separate parameter set?
There was a problem hiding this comment.
I was under the impression that each parameter set needed a particular dt to make the assertions hold below.
There was a problem hiding this comment.
Don't want to get hung up on it and maybe misreading, but doesn't the original test always use 01-02-2008 as the dt value? Where did 2014-07-01 come from?
There was a problem hiding this comment.
Oh! My mistake. Previous I thought this used the dt fixture defined above in this file but it looks like it didn't. Looks like I can simplify this parameterization all together.
I modified |
There was a problem hiding this comment.
lgtm when green. thanks for doing this @mroeschke - I think helps with the test suite readability and maintenance a lot
No description provided.