support tuple in startswith/endswith for arrow strings #56580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rohanjain101
commented
Dec 20, 2023
| result = getattr(ser.str, side)(pat, na=na) | ||
| expected = pd.Series(exp, dtype=ArrowDtype(pa.bool_())) | ||
| tm.assert_series_equal(result, expected) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("side", ("startswith", "endswith")) | ||
| def test_str_starts_ends_with_all_nulls_empty_tuple(side): |
There was a problem hiding this comment.
I added this test because in case of empty tuple, code to create series is:
result = pc.if_else(pc.is_null(self._pa_array), None, False)
I thought that if self._pa_array was all nulls, that resulting datatype may be null[pyarrow] (when we want bool[pyarrow]), I added this test to validate that bool is preserved, even in all nulls case.
yuanx749
suggested changes
Dec 21, 2023
Co-authored-by: Xiao Yuan <yuanx749@gmail.com>
Co-authored-by: Xiao Yuan <yuanx749@gmail.com>
phofl
approved these changes
Dec 21, 2023
phofl
added
Strings
|
thx @rohanjain101 |
cbpygit
pushed a commit
to cbpygit/pandas
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.