CoW: Set a bunch of Series copy statements to False #56520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
approved these changes
Dec 21, 2023
|
Thanks! Do you know if there are still many other places as well to further check this, or was this already the result of a more or less full search? |
|
I searched in the past already, I think we got most cases, but wouldn't guarantee 100% coverage |
|
No 100% guarantee needed ;) Just to know if we need to actively track this as a further TODO item |
|
I don't think so, but I reserve the right to change this statement when we switch over and see a bunch of regressions in the asvs :) |
cbpygit
pushed a commit
to cbpygit/pandas
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the default is now
copy=Truefor numpy array input when CoW is enabled, we can explicitly disable copying when we know the data is newly generated.