PERF: Improve performance when hashing a nullable extension array #56508
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Dec 14, 2023
| @@ -1994,7 +1994,7 @@ def _hash_pandas_object( | |||
| ... hash_key="1000000000000000", | |||
| ... categorize=False | |||
| ... ) | |||
| array([11381023671546835630, 4641644667904626417], dtype=uint64) | |||
| array([ 6238072747940578789, 15839785061582574730], dtype=uint64) | |||
There was a problem hiding this comment.
Would be good to note that hashing values for masked EA types changed in Other API Changes
rhshadrach
added
hashing
cbpygit
pushed a commit
to cbpygit/pandas
that referenced
this pull request
Jan 2, 2024
…ndas-dev#56508) * PERF: Improve performance when hashing a nullable extension array * Fixup * Add whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the roundtrip through object, this is much faster (around 15x)