Skip to content

DOC: Explicit how 'cond' is updated on 'where' #56286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

aureliobarbosa
Copy link
Contributor

This PR updates the section notes on DataFrame.where(cond, other=nan, *, inplace=False, axis=None, level=None) docstring.
Currently pandas isn't explicit on who is being updated when cond is misaligned with other. Just made that explicit to avoid confusion.

@samukweku
Copy link
Contributor

@aureliobarbosa kindly link your PR to the GitHub issue

@aureliobarbosa
Copy link
Contributor Author

@samukweku There is no open issue related to this PR. I found the problem and just tried to fix it directly through a PR because recently I did the same on CPython and there the instructions were clear that if it where very small contribution (typo, link, etc) it wasn't necessary to open an issue.

I just added three words to definite a relation explicitly. Should I open a new issue?

@samukweku
Copy link
Contributor

samukweku commented Dec 1, 2023

Kindly ignore my comments . I'll let @pandas-dev/pandas-core team speak on this. @phofl @Dr-Irv

Copy link
Contributor

github-actions bot commented Jan 1, 2024

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jan 1, 2024
@Dr-Irv Dr-Irv merged commit bd331ed into pandas-dev:main Jan 2, 2024
@aureliobarbosa aureliobarbosa deleted the doc-series-where branch March 5, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants