Skip to content

ENH: all-NaT-> infer second resolution #56103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

ENH: all-NaT-> infer second resolution #56103

merged 1 commit into from
Nov 22, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Non-Nano datetime64/timedelta64 with non-nanosecond resolution labels Nov 22, 2023
mroeschke
mroeschke reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be good to note this in the whatnew notes? Seems like notable behavior change (improvement)

@jbrockmendel
Copy link
Member Author

shouldnt affect any users since it wont go live until 3.0

@mroeschke mroeschke modified the milestones: 2.1.4, 2.2 Nov 22, 2023
@mroeschke mroeschke merged commit e37ff77 into pandas-dev:main Nov 22, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the enh-reso-nat branch November 22, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Non-Nano datetime64/timedelta64 with non-nanosecond resolution
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke