BUG: DTA/TDA constructors with mismatched values/dtype resolutions #55658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 24, 2023
| # "type[DatetimeArray]", variable has type "type[PeriodArray]") | ||
| cls = dtype.construct_array_type() # type: ignore[assignment] | ||
| dt64_values = arr.view(f"M8[{dtype.unit}]") | ||
| return cls(dt64_values, dtype=dtype) | ||
| elif dtype == "M8[ns]": |
There was a problem hiding this comment.
Why do just the ns cases need special casing?
There was a problem hiding this comment.
i also have a branch to extend this check to other supported dt64/td64 dtypes, just trying to keep this branch targeted
mroeschke
approved these changes
Oct 24, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.