CLN/TST: clean logic of old datetime test_indexing test #55523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-430
to
+431
| expected = ts["2001"] | ||
| expected.name = "A" | ||
| result = ts["2001"] | ||
| tm.assert_series_equal(result, ts.iloc[:12]) |
There was a problem hiding this comment.
This expected wasn't actually being used right now, and it's the result of the "getting" operation (with a timeseries partial indexing), so asserting the result instead.
Comment on lines
444
to
+445
| ts["2001"] = 1 | ||
| expected = ts["2001"] | ||
| expected.name = "A" | ||
| tm.assert_series_equal(ts, expected) |
There was a problem hiding this comment.
Similarly here, the result of setting ts["2001"] = 1 was no longer tested, and expected wasn't actually used
Comment on lines
-447
to
-448
| with pytest.raises(KeyError, match="2001"): | ||
| df["2001"] |
There was a problem hiding this comment.
Duplicated with 10 lines above
mroeschke
approved these changes
Oct 15, 2023
|
Thanks @jorisvandenbossche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking off a change I had to make for #55428, because it's actually unrelated to CoW and reduces the diff there a little bit.
I think that this test has over time, through several small changes, become quite useful / incomprehensible. So cleaning it up, and actually asserting what my understanding is that it was originally testing.