Skip to content

BUG: pct_change showing unnecessary FutureWarning #54983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2023
Merged

BUG: pct_change showing unnecessary FutureWarning #54983

merged 4 commits into from
Sep 6, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 3, 2023

@phofl phofl added the Warnings Warnings that appear or should be added to pandas label Sep 3, 2023
@phofl phofl added this to the 2.1.1 milestone Sep 3, 2023
@torext
Copy link
Contributor

torext commented Sep 5, 2023

@phofl I arrived here because I was about to submit a bug report on this issue. However, looking at the commited change above I notice it won't fix the issue for DataFrames: the 3 changed lines in pandas/core/generic.py only work if self is a Series, not when it's a DataFrame, I believe.

@phofl
Copy link
Member Author

phofl commented Sep 5, 2023

good point, fixed

@mroeschke mroeschke merged commit 88683e9 into pandas-dev:main Sep 6, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the 54981 branch September 6, 2023 22:40
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 6, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 6, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#54983: BUG: pct_change showing unnecessary Fut…
3e52656 
…ureWarning
mroeschke pushed a commit that referenced this pull request Sep 7, 2023
@meeseeksmachine @phofl
Backport PR #54983 on branch 2.1.x (BUG: pct_change showing unnecessa…
6db7b00 
…ry FutureWarning) (#55040)

Backport PR #54983: BUG: pct_change showing unnecessary FutureWarning

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
@phofl @mroeschke
BUG: pct_change showing unnecessary FutureWarning (pandas-dev#54983)
eb637dc 
* BUG: pct_change showing unnecessary FutureWarning

* Fix df case

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

BUG: FutureWarning on pct_change() suggests a solution that does not always work.
3 participants
@phofl @torext @mroeschke