Skip to content

typing improvements on level and fill_value in Series.eq #54729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2023
Merged

typing improvements on level and fill_value in Series.eq #54729

merged 4 commits into from
Aug 25, 2023

Conversation

color455nm
Copy link
Contributor

@color455nm color455nm commented Aug 24, 2023 •
edited
Loading

@color455nm
Copy link
Contributor Author

pyladies-aug23-sprint : @phofl @noatamir

@mroeschke mroeschke added the Sprints Sprint Pull Requests label Aug 24, 2023
twoertwein
twoertwein reviewed Aug 25, 2023
View reviewed changes
twoertwein
twoertwein reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looks good to me!

@twoertwein twoertwein merged commit b1192b3 into pandas-dev:main Aug 25, 2023
@twoertwein
Copy link
Member

Thanks @color455nm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
Sprints Sprint Pull Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@color455nm @twoertwein @mroeschke