Skip to content

BUG: Fixes #54617 Dataframe to html for empty array with complex dtypes #54451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 8, 2023

Conversation

soumya1729
Copy link
Contributor

@soumya1729 soumya1729 commented Aug 7, 2023

@soumya1729 soumya1729 changed the title Fresh new feature BUG: Fixes #54617 Dataframe to html for empty array with complex dtypes Aug 7, 2023
@mroeschke mroeschke added IO HTML read_html, to_html, Styler.apply, Styler.applymap Complex Complex Numbers labels Aug 7, 2023
@mroeschke mroeschke added this to the 2.1 milestone Aug 7, 2023
@mroeschke
Copy link
Member

Thanks could you add an entry in 2.1.0.rst in the IO section?

@soumya1729
Copy link
Contributor Author

@mroeschke yeah done!

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@soumya1729
Copy link
Contributor Author

@mroeschke scripts/tests/test_sort_whatsnew_note.py test_sort_whatsnew_note hook seems to be failing in pre-commit.ci

@mroeschke mroeschke merged commit 2451b42 into pandas-dev:main Aug 8, 2023
@mroeschke
Copy link
Member

Thanks @soumya1729

@soumya1729
Copy link
Contributor Author

@mroeschke Was a great learning curve,thanks!

mroeschke added a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
…mplex dtypes (pandas-dev#54451)

* Fresh new feature

* Removed html file, put it in string in the test

* Html test against hash value

* Removing prints

* Keeping inline html instead of mdlib hex

* added an entry in the io section

* Update doc/source/whatsnew/v2.1.0.rst

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

* Modifying rst file

* Sorted rst file after manual run of precommit on local

---------

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complex Complex Numbers IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame html repr does not work for complex dtypes if DataFrame is empty
2 participants