DOC Update Documentation in "missing_data" 54028 #54448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Aug 7, 2023
| .. note:: | ||
| If you are adding type checking to your application, you may need access to ``NaTType`` and ``NAType``. | ||
|
|
||
| ``NaTTYPE`` and ``NAType`` have now been added and can be imported from "pandas.api.typing". |
There was a problem hiding this comment.
you don't need this sentence here
There was a problem hiding this comment.
you don't need this sentence here
Which sentence are you referring to?
There was a problem hiding this comment.
you don't need this sentence here
If you mean the entire comment would you suggest somewhere else where it fits better?
There was a problem hiding this comment.
I have updated the PR, if you could please take a look.
mroeschke
approved these changes
Aug 8, 2023
|
Thanks @omar-elbaz |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
* first commit * updated missing data * datetimes updated doc * datetime update (2) * Update with Pre-commit * Doc_Updates * Doc Update * Missing_Data Update * review_update --------- Co-authored-by: Omar Elbaz <omarelbaz@omars-air.mynetworksettings.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54028 DOC: Add NAType and NaTType references in docs for pandas.api.typing
Adds reference notes for importing NaType and NaTType