#53718 Added copy_on_write effects on pd.Dataframe.copy() method #54425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
taytzehao
commented
Aug 5, 2023
taytzehao
commented
- closes DOC: Update the DataFrame.copy docstring to note different behaviour with Copy-on-Write #53718
- All code checks passed.
phofl
reviewed
Aug 5, 2023
pandas/core/generic.py
Outdated
|
|
||
| ** Copy-on-Write is set to true: ** | ||
|
|
||
| >>> pd.set_option("mode.copy_on_write", True) |
There was a problem hiding this comment.
This will set the option to True for all following tests as well, this has to be wrapped in with(pd.options_context...)
mroeschke
reviewed
Aug 9, 2023
pandas/core/generic.py
Outdated
| @@ -6584,6 +6584,13 @@ def copy(self, deep: bool_t | None = True) -> Self: | |||
| :ref:`gotchas <gotchas.thread-safety>` when copying in a threading | |||
| environment. | |||
|
|
|||
| When ``copy_on_write`` in pandas global config is set to ``True``, the | |||
| ``copy_on_write`` global config take effect even when ``deep=False``. | |||
There was a problem hiding this comment.
Suggested change
| ``copy_on_write`` global config take effect even when ``deep=False``. | |
| ``copy_on_write`` global config takes effect even when ``deep=False``. |
mroeschke
reviewed
Aug 9, 2023
pandas/core/generic.py
Outdated
| When ``copy_on_write`` in pandas global config is set to ``True``, the | ||
| ``copy_on_write`` global config take effect even when ``deep=False``. | ||
| This means that any changes to the copied data would make a new copy | ||
| of the data upon write (and vice versa). o changes would not be reflected |
mroeschke
approved these changes
Aug 10, 2023
|
Thanks @taytzehao |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
…ethod (pandas-dev#54425) * reformat * iloc * option_context * tab spacing * reformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.