Skip to content

TST / CoW: Adjust test to cover missing case #54114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2023
Merged

TST / CoW: Adjust test to cover missing case #54114

merged 2 commits into from
Jul 17, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jul 13, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This was actually working as expected, but we did not test it yet

@phofl phofl requested a review from jorisvandenbossche July 13, 2023 20:14
@jorisvandenbossche jorisvandenbossche changed the title CoW: Adjust test to cover missing case TST / CoW: Adjust test to cover missing case Jul 17, 2023
jorisvandenbossche
jorisvandenbossche approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@jorisvandenbossche jorisvandenbossche merged commit 4d9a6e4 into pandas-dev:main Jul 17, 2023
@phofl phofl deleted the cow_adjust_test branch July 17, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Copy / view semantics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jorisvandenbossche