Skip to content

DEV: Improves Error msg when constructing a Timedelta #54098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2023
Merged

DEV: Improves Error msg when constructing a Timedelta #54098

merged 5 commits into from
Jul 17, 2023

Conversation

mcgeestocks
Copy link
Contributor

@mcgeestocks mcgeestocks marked this pull request as ready for review July 13, 2023 00:30
MarcoGorelli
MarcoGorelli reviewed Jul 13, 2023
View reviewed changes
MarcoGorelli
MarcoGorelli reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just need a whatsnew note (2.1.0) and this can go in

I think there's an "other" section where similar error message improvements are sometimes reported

mroeschke
mroeschke reviewed Jul 13, 2023
View reviewed changes
@mroeschke mroeschke added the Error Reporting Incorrect or improved errors from pandas label Jul 13, 2023
mroeschke
mroeschke reviewed Jul 13, 2023
View reviewed changes
@mcgeestocks
Copy link
Contributor Author

Looks good to go @mroeschke / @MarcoGorelli

@mroeschke mroeschke added this to the 2.1 milestone Jul 17, 2023
@mroeschke mroeschke merged commit 9f240a2 into pandas-dev:main Jul 17, 2023
@mroeschke
Copy link
Member

Thanks @mcgeestocks

@mcgeestocks mcgeestocks deleted the error-msg branch July 17, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

DEV: Error in main branch when subtracting a valid numpy timedelta from a Series of timestamps
3 participants
@mcgeestocks @mroeschke @MarcoGorelli