Skip to content

DOC: to_datetime param format has no effect for df #54079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2023
Merged

DOC: to_datetime param format has no effect for df #54079

merged 2 commits into from
Jul 11, 2023

Conversation

natmokval
Copy link
Contributor

Updated docstring for to_datetime. Pointed out, that the parameter format has no effect if DataFrame is passed. Emphasized that in this case the column "year" must be specified in 4-digit format.

MarcoGorelli
MarcoGorelli reviewed Jul 11, 2023
View reviewed changes
MarcoGorelli
MarcoGorelli approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @natmokval , looks good on green

@MarcoGorelli MarcoGorelli added the Datetime Datetime data dtype label Jul 11, 2023
@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Jul 11, 2023
@natmokval natmokval marked this pull request as ready for review July 11, 2023 12:31
@MarcoGorelli MarcoGorelli merged commit 7ed7c7a into pandas-dev:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: to_datetime does not support format="%y%m%d"
2 participants
@natmokval @MarcoGorelli