Skip to content

BUG: checking for value type when parquet is partitioned #54074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 13, 2023
Merged

BUG: checking for value type when parquet is partitioned #54074

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd630ff
checking for value type when parquet is partitioned
SanjithChockan Jul 11, 2023
d754d1a
whatsnew formatting
SanjithChockan Jul 12, 2023
465c9d7
added whatsnew
SanjithChockan Jul 12, 2023
5423fc4
removed aliasing and skip_if_no_arrow decorator
SanjithChockan Jul 13, 2023
e184bc6
added unit test for valid pyarrow array of dictionary with string val…
SanjithChockan Jul 13, 2023
9bdb611
updated whatsnew with suggested changes
SanjithChockan Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/core/arrays/string_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,10 @@ def __init__(self, values) -> None:
super().__init__(values)
self._dtype = StringDtype(storage="pyarrow")

if not pa.types.is_string(self._pa_array.type):
if not pa.types.is_string(self._pa_array.type) and not (
pa.types.is_dictionary(self._pa_array.type)
and pa.types.is_string(self._pa_array.type.value_type)
):
raise ValueError(
"ArrowStringArray requires a PyArrow (chunked) array of string type"
)
Expand Down
1 change: 0 additions & 1 deletion pandas/io/parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ def write(
from_pandas_kwargs["preserve_index"] = index

table = self.api.Table.from_pandas(df, **from_pandas_kwargs)

path_or_handle, handles, filesystem = _get_path_or_handle(
path,
filesystem,
Expand Down