Skip to content

STY: Consolidate & add pre-commit checks #54047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2023
Merged

STY: Consolidate & add pre-commit checks #54047

merged 3 commits into from
Jul 10, 2023

Conversation

mroeschke
Copy link
Member

  • Adds some easy/useful pre-commit-hooks and pygrep-hooks
  • Consolidates & de-duplicates some redundant pre-commit pygrep checks

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Jul 7, 2023
@mroeschke mroeschke added this to the 2.1 milestone Jul 10, 2023
MarcoGorelli
MarcoGorelli reviewed Jul 10, 2023
View reviewed changes
.pre-commit-config.yaml
types_or: [python, cython, rst]
exclude: ^doc/source/development/code_style\.rst # contains examples of patterns to avoid
- id: cython-casting
Copy link
Member

@MarcoGorelli MarcoGorelli Jul 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one covered by anything else? (not a blocker, arguably it should go into cython-lint)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is in id: unwanted-patterns-in-cython (would be nice if this was in cython-lint!)

MarcoGorelli
MarcoGorelli approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good on green

@mroeschke
Copy link
Member Author

Failures are unrelated here, so merging

@mroeschke mroeschke merged commit f725c1e into pandas-dev:main Jul 10, 2023
@mroeschke mroeschke deleted the sty/misc_checks branch July 10, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @MarcoGorelli