Skip to content

REF: de-duplicate CoW helpers #53899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

REF: de-duplicate CoW helpers #53899

merged 1 commit into from
Jun 28, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke requested a review from phofl June 28, 2023 15:56
@mroeschke mroeschke added Refactor Internal refactoring of code Copy / view semantics labels Jun 28, 2023
phofl
phofl approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phofl phofl added this to the 2.1 milestone Jun 28, 2023
@phofl phofl merged commit 409b344 into pandas-dev:main Jun 28, 2023
@jbrockmendel jbrockmendel deleted the ref-has_refs-4 branch June 28, 2023 16:13
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@jbrockmendel
REF: de-duplicate CoW helpers (pandas-dev#53899)
97560f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Copy / view semantics Refactor Internal refactoring of code
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @phofl @mroeschke