ENH: HDFStore.flush() to optionally perform fsync (GH5364) #5369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now, probably not worth it, because we don't have much that really needs it (might be nice for network tests but a little too late now). |
| distributed lock manager to ensure there is only a single writer at a | ||
| time and all readers close the file during writes and re-open it after any | ||
| writes. In this case you should use ``store.flush(fsync=True)`` prior to | ||
| releasing any write locks. See the issue (:`5364`) for more information. |
There was a problem hiding this comment.
can you shorten this to:
If you use locks to manage write access between multiple processes, you may want to use :py:func:`~os.fsync` before releasing write locs. For convenience you can use ``store.flush(fsync=True)`` to do this for you.
TST: Modifications to unit test following PR 5369 review.
jreback
added a commit
that referenced
this pull request
Oct 29, 2013
ENH: HDFStore.flush() to optionally perform fsync (GH5364)
|
thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for #5364.
The
fsync=Falseparameter was added toflushgiven this offers utility for non-distribution use cases, such as a user just wanting to ensure their data is regularly flushed to disk.I could not see any mocking library in use in the Pandas tests, so I skipped adding one just to verify
os.fsyncactually gets called.