BLD: Fix compiling pandas with a venv located in the src dir #53489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chatted offline with Brock about this and it seems to fix the issues he's been having (at least with compiling pandas in a venv). Planning on merging on this on green. |
rhshadrach
reviewed
Jun 1, 2023
Comment on lines
+7
to
+13
| try: | ||
| # Check if include directory is inside the pandas dir | ||
| # e.g. a venv created inside the pandas dir | ||
| # If so, convert it to a relative path | ||
| incdir = os.path.relpath(np.get_include()) | ||
| except Exception: | ||
| incdir = np.get_include() |
There was a problem hiding this comment.
Just wondering if you're expecting relpath to raise if the path is not a subdirectory. It doesn't:
import os
print(os.getcwd())
# /home/richard/dev
print(os.path.relpath('/home/richard/dev'))
# '.'
print(os.path.relpath('/home/richard/dev/pandas'))
# pandas
print(os.path.relpath('/home/richard'))
# ..
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Jun 5, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jbrockmendel can you give this a shot?