-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: to_datetime re-parsing Arrow-backed objects #53301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
234021a
BUG: to_datetime re-parsing Arrow-backed objects
lithomas1 e4b3d0f
Address code comments
lithomas1 76fd635
address code review
lithomas1 2fc915b
Merge branch 'main' of https://github.com/pandas-dev/pandas into arro…
lithomas1 4ba7a65
fix test
lithomas1 ed80297
fix test
lithomas1 9b593ff
Merge branch 'main' of https://github.com/pandas-dev/pandas into arro…
lithomas1 2630740
update
lithomas1 325e792
xfail on windows
lithomas1 bccd932
skip on windows instead
lithomas1 f372d25
fix mypy
lithomas1 64478d7
fix
lithomas1 a03c823
remove accidental
lithomas1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
tz_localize
always the right one, or do we needtz_convert
if the input was timezone-aware to begin with?In the test you've added,
dti_arrow
is always timezone-naive - would we make a timezone-aware example too please, just to check this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the catch.
I messed up the test (it does parametrize over UTC and US/Central), but I forgot to propagate the tz information in the tests.