DEPR Rename keyword "quantile" to "q" in Rolling.quantile
#53216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Deprecate
phofl
reviewed
May 14, 2023
phofl
reviewed
May 14, 2023
|
Could you deprecate this on |
mroeschke
reviewed
May 16, 2023
|
In rolling.py there's also this "private" quantile function could you change |
Sure, and since it is a private function, no deprecation is needed right? |
Correct |
mroeschke
approved these changes
May 17, 2023
|
Thanks @Charlie-XIAO |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
…ev#53216) * deprecated 'quantile' arg in Rolling.quantile * renamed keyword 'quantile' to 'q' in Rolling.quantile * fixed test * docstring modified, removed unnecessary descriptions and typos * resolved conversations * deprecate on Expanding as well * resolved conversations; renamed in parent
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…ev#53216) * deprecated 'quantile' arg in Rolling.quantile * renamed keyword 'quantile' to 'q' in Rolling.quantile * fixed test * docstring modified, removed unnecessary descriptions and typos * resolved conversations * deprecate on Expanding as well * resolved conversations; renamed in parent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.1.0.rstfile