BUG: PeriodDtype incorrectly caching different DateOffset freqs #52991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pandas/core/dtypes/dtypes.py:902: error: Incompatible types in assignment (expression has type "Dict[int, PandasExtensionDtype]", base class "PandasExtensionDtype" defined the type as "Dict[str, PandasExtensionDtype]") [assignment] This is one of the complaints I've been seeing locally for a while. No idea why its showing up now |
pandas/tests/arrays/test_period.py
Outdated
| @@ -22,6 +22,15 @@ def test_registered(): | |||
| assert result == expected | |||
|
|
|||
|
|
|||
| def test_perioddtype_caching_dateoffset_normalize(): | |||
There was a problem hiding this comment.
Can this go with other PeriodDtype tests (as opposed to the Array)
jbrockmendel
reviewed
May 1, 2023
pandas/core/dtypes/dtypes.py
Outdated
| @@ -899,7 +899,7 @@ class PeriodDtype(PeriodDtypeBase, PandasExtensionDtype): | |||
| num = 102 | |||
| _metadata = ("freq",) | |||
| _match = re.compile(r"(P|p)eriod\[(?P<freq>.+)\]") | |||
| _cache_dtypes: dict[int, PandasExtensionDtype] = {} | |||
| _cache_dtypes: dict[BaseOffset, PandasExtensionDtype] = {} # type: ignore[assignment] # noqa:E501 | |||
There was a problem hiding this comment.
missing the usual "# error: ..." in the previous line? should the value be PeriodDtype instead of PandasExtensionDtype?
jbrockmendel
approved these changes
May 2, 2023
|
thanks @mroeschke |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
…as-dev#52991) * BUG: PeriodDtype incorrectly caching different DateOffset freqs * Change typing * Address review * Add more specific typing and error message
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
…as-dev#52991) * BUG: PeriodDtype incorrectly caching different DateOffset freqs * Change typing * Address review * Add more specific typing and error message
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…as-dev#52991) * BUG: PeriodDtype incorrectly caching different DateOffset freqs * Change typing * Address review * Add more specific typing and error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.