Skip to content

DOC: Fix EX01 issues in docstrings #52966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Conversation

DeaMariaLeon
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Towards #37875

@mroeschke mroeschke added the Docs label Apr 27, 2023
@mroeschke mroeschke added this to the 2.1 milestone Apr 27, 2023
@mroeschke mroeschke merged commit 0f47de6 into pandas-dev:main Apr 27, 2023
@mroeschke
Copy link
Member

Nice as always @DeaMariaLeon

@DeaMariaLeon
Copy link
Member Author

Thanks @mroeschke for reviewing and merging. I have some questions:

  1. Do you prefer that I include more examples per PR or is "little by little" OK?
  2. Should I avoid many commits and send just one? I think I should use git rebase..

@mroeschke
Copy link
Member

Do you prefer that I include more examples per PR or is "little by little" OK?

I am okay with more examples per PR. Personally, I would say no more than addressing 10 functions per PR

Should I avoid many commits and send just one? I think I should use git rebase..

No need to worry about this. When your PRs are merged, the commits are squashed all together.

@DeaMariaLeon
Copy link
Member Author

OK, good to know both points.
Thanks.

topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
* DOC added examples

* DOC added examples

* DOC Removed lines from code_check

* DOC examples __iter__ not needed?
@DeaMariaLeon DeaMariaLeon deleted the examples branch May 8, 2023 17:03
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
* DOC added examples

* DOC added examples

* DOC Removed lines from code_check

* DOC examples __iter__ not needed?
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* DOC added examples

* DOC added examples

* DOC Removed lines from code_check

* DOC examples __iter__ not needed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants