CLN: clean-up numpy/function.py #52648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
commented
Apr 13, 2023
| "median": validate_median, | ||
| "mean": validate_mean, | ||
| "min": validate_min, | ||
| "max": validate_max, |
There was a problem hiding this comment.
Note that in main, the validate_mean, validate_min and validate_max were not used.
There was a problem hiding this comment.
if they're not used, let's delete them
There was a problem hiding this comment.
Sorry, I wasn't precise, what I meant was that they weren't used here. They are used elsewhere and it makes sense to use them here also to ensure the same API for same-named methods .
mroeschke
approved these changes
Apr 13, 2023
|
Thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simplifications in numpy/functions.py