CLN/ENH: Make names getattr'able in core/ops +PEP8. #5240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the name passed to a method can be used to get that method from the NDFrame (previously you had things like `or_ [|]`. better to just have them all be named exactly what they are s.t. subclasses can do `getattr(super(self, MyClass), name)(*args, **kwargs)`.
|
looks fine |
jtratner
added a commit
that referenced
this pull request
Oct 16, 2013
CLN/ENH: Make names getattr'able in core/ops +PEP8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the name passed to a method can be used to get that method from the
NDFrame (previously you had things like
or_ [|]. better to just have themall be named exactly what they are s.t. subclasses can do
getattr(super(self, MyClass), name)(*args, **kwargs).