Skip to content

STYLE Remove flake8-rst #51843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

DeaMariaLeon
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

flake8-rst is unmantained. It causes errors on Python3.10 - (Explanation by @MarcoGorelli)

@DeaMariaLeon DeaMariaLeon added the Code Style Code style, linting, code_checks label Mar 8, 2023
@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Mar 8, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DeaMariaLeon !

there's an issue about replacing flake8-rst with something maintained, if we find it we can use that. for now, if this one keeps causing issues (I've run into issues with it on newer Python versions), it's probably best to just get rid of it

@DeaMariaLeon
Copy link
Member Author

Thanks @MarcoGorelli
Linking to the issue you mention: #46865

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, let's merge, and if/when we find an alternative we can put it back

thanks @DeaMariaLeon !

@MarcoGorelli MarcoGorelli merged commit 2a067ba into pandas-dev:main Mar 8, 2023
@mroeschke
Copy link
Member

So confirming we won't have flake8 checking on our rst files in the meantime?

@DeaMariaLeon DeaMariaLeon deleted the flake8rstremove branch March 9, 2023 12:34
@DeaMariaLeon
Copy link
Member Author

That's what I understand @mroeschke.

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Mar 9, 2023

that's right unfortunately...I'll see if I can fork it, shouldn't be too big of a deal to make it compatible with latest versions of things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants