-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Use PyCapsule for internal datetime functions #51525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
431495b
initial file setup and build
WillAyd c3dca72
Building standalone impl
WillAyd d77a2ed
more build
WillAyd 4525e77
linting
WillAyd 782b971
more updates
WillAyd 69abccd
Capsule location change
WillAyd 69460bd
working import
WillAyd 776f0f5
working imports?
WillAyd c4a05b5
moved lots
WillAyd a995ee2
Working impl
WillAyd 05e28ad
styling
WillAyd d938374
import cleanups
WillAyd df687b3
revert init change
WillAyd a26f312
cleanups
WillAyd 96b6f96
isort fixups
WillAyd 7b28333
api test fix
WillAyd ccea2b3
removed unneeded tokenizer add
WillAyd 2bf7264
Hacked together parser capsule
WillAyd 418910d
Symbol cleanups
WillAyd a4f7e1a
Resolved all undefined symbols in parsers.pyx
WillAyd ad1d149
IO callbacks restored
WillAyd 5887254
Fix build and test failures
WillAyd 138ea0d
Try relative imports for MSFT compat
WillAyd 679d03d
try py_ssize_t_clean macro
WillAyd 7c4e365
Removed double tokenizer include
WillAyd 5aee18a
removed unneeded include path
WillAyd a0523be
more cleanups
WillAyd 554d701
noexcept
WillAyd 726d93d
signature cleanup
WillAyd d2fe542
simplify parser impl
WillAyd 49a2739
retain np_datetime_string license
WillAyd 3981ec2
retained old file structure where possible
WillAyd fb75100
Commited C file
WillAyd f51e7f4
Removed erroneous comments
WillAyd 709bf6c
Merge branch 'main' into np-datetime-capsule
WillAyd f4dac4f
graft pd_parser.c
WillAyd 7fd0a49
Merge branch 'main' into np-datetime-capsule
WillAyd 12179c7
graft -> include
WillAyd 67f5445
Merge remote-tracking branch 'upstream/main' into np-datetime-capsule
WillAyd 9271ce3
Merge branch 'main' into np-datetime-capsule
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of this, but capsules currently cannot be attached to anything but a top level package. See python/cpython#6898 which I think would solve this, but for now this has to be attached to the top level namespace and really come before anything else to avoid circular import errors