DEP: Enforce deprecation of squeeze in read_excel #51481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
IO Excel
pandas/io/excel/_base.py
Outdated
Comment on lines
900
to
888
| if not squeeze or isinstance(output[asheetname], DataFrame): | ||
| if isinstance(output[asheetname], DataFrame): |
There was a problem hiding this comment.
just for my understanding - previously, isinstance(output[asheetname], DataFrame) would only have been evaluated if squeeze was True. Now that that option is False always (because squeeze has been removed), then can this whole if statement be removed?
There was a problem hiding this comment.
good point, thx. Yes we always get back a DataFrame, so can remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.looks like we missed a deprecation.
cc @MarcoGorelli for a quick look?