BUG: Fix GroupBy.idxmin/idxmax retrun wrong type on empty #51423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/groupby/generic.py
Outdated
| func.__name__ = "idxmax" | ||
| return self._idxmin_idxmax(func) | ||
|
|
||
| def _idxmin_idxmax(self, func: Callable) -> DataFrame | Series: |
There was a problem hiding this comment.
what if instead of all this you just did return result.astype(self.obj.index.dtype, copy=False)
There was a problem hiding this comment.
It seems that there are some problems with implementing it directly like this.
If it's better to make minimal changes to the code on the existing basis in this way, I will go ahead and fix these problem on this basis..
There was a problem hiding this comment.
I think we can't dtype directly to all result, because there are some types can't be converted to each other, such as inf and NA.
Therefore, I tried to convert only the empty result. Based on the original code, the type is incorrect only when the return value is empty.
@jbrockmendel any suggestion?
luke396
force-pushed
the
idxmin-idxmax-retrun-wrong-type
branch
from
7854611 to
ae26c2e
Compare
luke396
requested review from
jbrockmendel
and removed request for
jbrockmendel
|
Thanks @luke396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.