add typehint for None pct_change #51343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Looks good to me!
The documentation already mentions None:
fill_method : {'backfill', 'bfill', 'pad', 'ffill', None}, default 'pad'
How to handle NAs **before** computing percent changes.
but it might be nice to explain what None actually does (or reference to which function that parameter is forwarded to - presumably fillna?).
you're right, thanks agree that it would be good to document what passing |
|
Would you like me to write docs on this branch / PR, or should that be done on another? |
MarcoGorelli
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
another one is fine, might as well get this in - thanks @FlynnOwen !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a typehint for None. It looks like supplying
Noneas an argument tofill_methodis tested for dataframes underpandas/tests/series/methods.Let me know if another test should be written, e.g for dataframes.