Skip to content

TST: Test mask/where inplace don't modify views with CoW #51303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

df = DataFrame({"a": [1.5, 2, 3]})
df_orig = df.copy()
arr_a = get_array(df, "a")
view = df[:] # noqa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this (might have forgotten this as well), you are using view again a bit further down

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch, updated your tests as well.

@lithomas1 lithomas1 marked this pull request as ready for review February 10, 2023 17:14
@lithomas1 lithomas1 added Testing pandas testing functions or related to the test suite Copy / view semantics labels Feb 10, 2023
@lithomas1 lithomas1 added this to the 2.0 milestone Feb 10, 2023
@phofl
Copy link
Member

phofl commented Feb 10, 2023

Failure unrelated

@phofl phofl merged commit cf2d8f9 into pandas-dev:main Feb 10, 2023
@phofl
Copy link
Member

phofl commented Feb 10, 2023

thx @lithomas1

@lithomas1 lithomas1 deleted the test-mask-where branch February 10, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy / view semantics Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants