TST: win32 paths cannot be turned into URLs by prefixing them with "file://" v2

[mindw]

Rebased on master (unable to use same pull request). Closes #4580.

see http://stackoverflow.com/questions/11687478/convert-a-filename-to-a-file-url

[jreback]

@cpcloud for 0.13?

[jreback]

@cpcloud 0.13?

[cpcloud]

@mindw Can you rebase? We'd like to get this in for 0.13 (by next week). Thanks!

[mindw]

rebase to where?

[cpcloud]

Rebase to this PR.

Assuming you're on the local branch associated with this PR:

# add pandas upstream if you don't have it already
git remote add upstream git://github.com/pydata/pandas.git

# fetch upstream changes (do this anyway)
git fetch upstream

# rebase on top of upstream/master (this is current master)
git rebase upstream/master

# force push
git push --force

You might need to resolve merge conflicts before force pushing.

[mindw]

ping.

[jreback]

@cpcloud pls review this, or can defer to 0.14....up2u

[jreback]

bumping to 0.14, unless reviewed before

[jtratner]

I'll take it.

[jtratner]

I'd prefer the io/common name to be file_path_to_url - seems clearer. Otherwise should be fine, so long as it passes Travis.

[jtratner]

Also please rebase again and squash your commits together.

[mindw]

Ok, please review.

Why was it pushed to 0.14 again?

[jtratner]

please remove this extra line.

[mindw]

Ok.

[jtratner]

this is fine, just remove the line.

I can't merge this until you enable Travis though - looks like you had it set up months ago - see more here - https://github.com/pydata/pandas/blob/master/CONTRIBUTING.md#steps-to-enable-travis-ci

[mindw]

I disabled it due to known test failures (test_fred?)

[jtratner]

those are fixed now, but can't merge this unless you set up Travis.

[mindw]

Ok fixed. Waiting in line.

-gabi

On Tue, Oct 29, 2013 at 12:13 AM, Jeff Tratner notifications@github.comwrote:

those are fixed now, but can't merge this unless you set up Travis.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5100#issuecomment-27262050
.

[jtratner]

thanks!