Skip to content

ENH: Add arrow tests for get_dummies #50951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2023
Merged

ENH: Add arrow tests for get_dummies #50951

merged 4 commits into from
Jan 26, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 24, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cc @mroeschke

did not want to clutter the other pr with this. Is there an easier way of defining the variables?

@mroeschke
Copy link
Member

Is there an easier way of defining the variables?

Could do [str(pd.ArrowDtype(typ) for typ in tm.ALL_...]?

@mroeschke mroeschke added the Arrow pyarrow functionality label Jan 24, 2023
@phofl
Copy link
Member Author

phofl commented Jan 26, 2023

Thx, makes sense. Updated

@mroeschke mroeschke added this to the 2.0 milestone Jan 26, 2023
@mroeschke mroeschke merged commit 16801a1 into pandas-dev:main Jan 26, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the get_dummies_arrow branch January 27, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke