CLN: Remove internal classes from MultiIndex pickle. #5084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perfect..so this will still exist, just not in pickles |
|
@jreback so something like this, where it's fixing something that never made it to any release. Should that go in release notes? |
|
nope (you could annotate the original) or even remove it |
FrozenNDArray had made it into the MI pickle. No reason to do that and just complicates pickle compat going forward. Now they just output ndarray instead (which also avoids the unnecessary nested pickle previously occurring).
jtratner
added a commit
that referenced
this pull request
Oct 2, 2013
CLN: Remove internal classes from MultiIndex pickle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrozenNDArray had made it into the MI pickle. No reason to do that and just
complicates pickle compat going forward. Now they just output ndarray
instead (which also avoids the unnecessary nested pickle previously
occurring).
Fixes #5076.