REF: stricter typing, better naming in parsing.pyx #50722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Datetime
MarcoGorelli
approved these changes
Jan 13, 2023
mroeschke
approved these changes
Jan 13, 2023
|
Thanks @jbrockmendel |
|
Because I couldn't find it in the changelog (probably because it's supposed to be an internal function no one should have actually used): We were using it in nextstrain/augur's parse to get information about the datetime resolution. Currently seeing how to migrate to pandas v2 given the removal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to move towards having fewer different string parsing paths.