Skip to content

BUG: Fix style.background_gradient() for nullable dtype (ex: Int64) series with pd.NA values #50713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 16, 2023
Merged

BUG: Fix style.background_gradient() for nullable dtype (ex: Int64) series with pd.NA values #50713

merged 10 commits into from
Jan 16, 2023

Conversation

dhendry
Copy link
Contributor

@dhendry dhendry commented Jan 12, 2023 •
edited
Loading

@dhendry dhendry mentioned this pull request Jan 12, 2023
Closed
3 tasks
attack68
attack68 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@attack68 attack68 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks a nice fix to me. Thanks

Test failures look unrelated - seems to be CI failure at the mom, but we can wait until its back to do a full chekc that this is green.

@dhendry
Copy link
Contributor Author

dhendry commented Jan 13, 2023

@attack68 Ok cool, I just re-merged master so hopefully it all works this time. If you look at one of the previous test runs, everything looks ok minus one windows test that seems somewhat flaky

image

Since then all I have done is re-merge master

mroeschke
mroeschke reviewed Jan 13, 2023
View reviewed changes
mroeschke
mroeschke reviewed Jan 13, 2023
View reviewed changes
mroeschke
mroeschke reviewed Jan 13, 2023
View reviewed changes
mroeschke
mroeschke requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

@mroeschke mroeschke added the Styler conditional formatting using DataFrame.style label Jan 13, 2023
dhendry and others added 2 commits January 13, 2023 13:57
@dhendry
Response to comments: move entry in whatsnew, include github issue in…
264b179 
… test, and check results against expected values from a regular float series
@dhendry
Merge branch 'pandas-dev:main' into main
adce6e0
@dhendry
Copy link
Contributor Author

dhendry commented Jan 13, 2023

All comments addressed.

@mroeschke @attack68 Thanks for the review

phofl
phofl reviewed Jan 14, 2023
View reviewed changes
dhendry and others added 2 commits January 16, 2023 09:24
@dhendry @phofl
Update doc/source/whatsnew/v2.0.0.rst
e24e052 
Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@dhendry
Merge branch 'main' into main
b464f42
@dhendry dhendry requested a review from mroeschke January 16, 2023 14:26
@mroeschke mroeschke added this to the 2.0 milestone Jan 16, 2023
@mroeschke mroeschke merged commit c128ffa into pandas-dev:main Jan 16, 2023
@mroeschke
Copy link
Member

Thanks @dhendry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

@mroeschke mroeschke mroeschke approved these changes

@attack68 attack68 attack68 approved these changes

Assignees
No one assigned
Labels
Styler conditional formatting using DataFrame.style
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: style.background_gradient() fails on nullable series (ex: Int64) with null values
4 participants
@dhendry @mroeschke @attack68 @phofl