BUG: ArrowDtype.construct_from_string round-trip #50689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might make sense to feature request this to Arrow to support parsing tz's in |
I'll do that separately, sure. |
|
issue has been opened upstream + green |
|
@mroeschke gentle ping on pyarrow-xfail PRs |
This was referenced Feb 10, 2023
mroeschke
reviewed
Feb 17, 2023
pandas/core/arrays/arrow/dtype.py
Outdated
| tail = tail[:-1] | ||
|
|
||
| if head == "timestamp": | ||
| if "," not in tail: |
There was a problem hiding this comment.
I don't think case needs handling
In [2]: pa.type_for_alias("timestamp[ns]")
Out[2]: TimestampType(timestamp[ns])
mroeschke
reviewed
Feb 17, 2023
mroeschke
reviewed
Feb 17, 2023
mroeschke
reviewed
Feb 18, 2023
| ArrowDtype.construct_from_string("timestamp[s, tz=UTC][pyarrow]") | ||
| ArrowDtype.construct_from_string("not_a_real_dype[s, tz=UTC][pyarrow]") | ||
|
|
||
| # but as of GH#50689, timestamptz is supported |
There was a problem hiding this comment.
In a follow up could you make this it's own test? (Nit: doesn't really fit the name of the test"
There was a problem hiding this comment.
fair enough, will do
|
CI timeouts unrelated, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.