Skip to content

BUG: is_numeric_dtype(ArrowDtype[numeric]) not returning True #50572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 6, 2023
Merged

BUG: is_numeric_dtype(ArrowDtype[numeric]) not returning True #50572

merged 4 commits into from
Jan 6, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 4, 2023 •
edited
Loading

@mroeschke mroeschke added Bug Arrow pyarrow functionality labels Jan 4, 2023
@mroeschke mroeschke added this to the 2.0 milestone Jan 5, 2023
@lukemanley
Copy link
Member

LGTM. failures look unrelated (same sqlalchemy issues hitting other PRs)

@mroeschke mroeschke merged commit 92e458d into pandas-dev:main Jan 6, 2023
@mroeschke mroeschke deleted the bug/arrow/is_numeric branch January 6, 2023 00:39
jrbourbeau
jrbourbeau reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing this @mroeschke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbourbeau jrbourbeau jrbourbeau left review comments

Assignees
No one assigned
Labels
Arrow pyarrow functionality Bug
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: is_numeric_dtype returns False for numeric ArrowDtypes
3 participants
@mroeschke @lukemanley @jrbourbeau