Skip to content

⬆️ UPGRADE: Autoupdate pre-commit config #50520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2023
Merged

⬆️ UPGRADE: Autoupdate pre-commit config #50520

merged 3 commits into from
Jan 3, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 1, 2023

Base PullRequest

default branch (https://github.com/pandas-dev/pandas/tree/main)

Command results

Details:
add path 
/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/build/src/bin
pip install pre-commit 
Defaulting to user installation because normal site-packages is not writeable
Collecting pre-commit
  Downloading pre_commit-2.21.0-py2.py3-none-any.whl (201 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 201.9/201.9 KB 4.2 MB/s eta 0:00:00
Collecting identify>=1.0.0
  Downloading identify-2.5.11-py2.py3-none-any.whl (98 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 98.8/98.8 KB 27.6 MB/s eta 0:00:00
Collecting nodeenv>=0.11.1
  Downloading nodeenv-1.7.0-py2.py3-none-any.whl (21 kB)
Collecting virtualenv>=20.10.0
  Downloading virtualenv-20.17.1-py3-none-any.whl (8.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 8.8/8.8 MB 101.1 MB/s eta 0:00:00
Collecting cfgv>=2.0.0
  Downloading cfgv-3.3.1-py2.py3-none-any.whl (7.3 kB)
Requirement already satisfied: pyyaml>=5.1 in /usr/lib/python3/dist-packages (from pre-commit) (5.4.1)
Requirement already satisfied: setuptools in /usr/lib/python3/dist-packages (from nodeenv>=0.11.1->pre-commit) (59.6.0)
Collecting distlib<1,>=0.3.6
  Downloading distlib-0.3.6-py2.py3-none-any.whl (468 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.5/468.5 KB 71.4 MB/s eta 0:00:00
Collecting filelock<4,>=3.4.1
  Downloading filelock-3.9.0-py3-none-any.whl (9.7 kB)
Collecting platformdirs<3,>=2.4
  Downloading platformdirs-2.6.2-py3-none-any.whl (14 kB)
Installing collected packages: distlib, platformdirs, nodeenv, identify, filelock, cfgv, virtualenv, pre-commit
Successfully installed cfgv-3.3.1 distlib-0.3.6 filelock-3.9.0 identify-2.5.11 nodeenv-1.7.0 platformdirs-2.6.2 pre-commit-2.21.0 virtualenv-20.17.1
pre-commit autoupdate || (exit 0); 
Updating https://github.com/MarcoGorelli/absolufy-imports ... [INFO] Initializing environment for https://github.com/MarcoGorelli/absolufy-imports.
already up to date.
Updating https://github.com/jendrikseipp/vulture ... [INFO] Initializing environment for https://github.com/jendrikseipp/vulture.
already up to date.
Updating https://github.com/codespell-project/codespell ... [INFO] Initializing environment for https://github.com/codespell-project/codespell.
already up to date.
Updating https://github.com/MarcoGorelli/cython-lint ... [INFO] Initializing environment for https://github.com/MarcoGorelli/cython-lint.
updating v0.9.1 -> v0.10.1.
Updating https://github.com/pre-commit/pre-commit-hooks ... [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
already up to date.
Updating https://github.com/cpplint/cpplint ... [INFO] Initializing environment for https://github.com/cpplint/cpplint.
already up to date.
Updating https://github.com/PyCQA/flake8 ... [INFO] Initializing environment for https://github.com/PyCQA/flake8.
already up to date.
Updating https://github.com/pycqa/pylint ... [INFO] Initializing environment for https://github.com/pycqa/pylint.
updating v2.15.6 -> v2.15.9.
Updating https://github.com/pycqa/pylint ... updating v2.15.6 -> v2.15.9.
Updating https://github.com/PyCQA/isort ... [INFO] Initializing environment for https://github.com/PyCQA/isort.
updating 5.10.1 -> 5.11.4.
Updating https://github.com/asottile/pyupgrade ... [INFO] Initializing environment for https://github.com/asottile/pyupgrade.
updating v3.2.2 -> v3.3.1.
Updating https://github.com/pre-commit/pygrep-hooks ... [INFO] Initializing environment for https://github.com/pre-commit/pygrep-hooks.
already up to date.
Updating https://github.com/sphinx-contrib/sphinx-lint ... [INFO] Initializing environment for https://github.com/sphinx-contrib/sphinx-lint.
already up to date.
Updating https://github.com/asottile/yesqa ... [INFO] Initializing environment for https://github.com/asottile/yesqa.
already up to date.
pre-commit run -a || (exit 0); 
[INFO] Initializing environment for https://github.com/codespell-project/codespell:tomli.
[INFO] Initializing environment for https://github.com/PyCQA/flake8:flake8-bugbear==22.7.1,flake8==6.0.0,pandas-dev-flaker==0.5.0.
[INFO] Initializing environment for https://github.com/asottile/yesqa:flake8-bugbear==22.7.1,flake8==6.0.0,pandas-dev-flaker==0.5.0.
[INFO] Initializing environment for local:black==22.10.0.
[INFO] Initializing environment for local:pyright@1.1.276.
[INFO] Initializing environment for local:flake8-rst==0.7.0,flake8==3.7.9.
[INFO] Initializing environment for local:pyyaml,toml.
[INFO] Initializing environment for local.
[INFO] Initializing environment for local:tomli.
[INFO] Initializing environment for local:flake8-pyi==22.8.1,flake8==5.0.4.
[INFO] Initializing environment for local:autotyping==22.9.0,libcst==0.4.7.
[INFO] Installing environment for https://github.com/MarcoGorelli/absolufy-imports.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/jendrikseipp/vulture.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/codespell-project/codespell.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/MarcoGorelli/cython-lint.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/cpplint/cpplint.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/PyCQA/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/asottile/pyupgrade.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/sphinx-contrib/sphinx-lint.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
absolufy-imports........................................................................................Passed
vulture.................................................................................................Passed
codespell...............................................................................................Passed
cython-lint.............................................................................................Failed
- hook id: cython-lint
- exit code: 1

pandas/_libs/tslibs/strptime.pyx:490:1: pointless string statement
pandas/_libs/algos.pyx:650:1: pointless string statement

double-quote Cython strings.............................................................................Passed
debug statements (python)...............................................................................Passed
fix end of files........................................................................................Passed
trim trailing whitespace................................................................................Passed
cpplint.................................................................................................Passed
flake8..................................................................................................Passed
isort...................................................................................................Passed
pyupgrade...............................................................................................Passed
rst ``code`` is two backticks...........................................................................Passed
rst directives end with two colons......................................................................Passed
rst ``inline code`` next to normal text.................................................................Passed
Sphinx lint.............................................................................................Passed
black...................................................................................................Passed
flake8-rst..............................................................................................Failed
- hook id: flake8-rst
- exit code: 1

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 486, in run_ast_checks
    ast = self.processor.build_ast()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/processor.py", line 212, in build_ast
    return compile("".join(self.lines), "", "exec", PyCF_ONLY_AST)
  File "", line 103
    @tm.network   # noqa
    ^
IndentationError: expected an indented block after 'with' statement on line 101

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/bin/flake8-rst", line 8, in <module>
    sys.exit(main())
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8_rst/cli.py", line 16, in main
    app.run(argv)
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 488, in run_ast_checks
    row, column = self._extract_syntax_information(e)
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 473, in _extract_syntax_information
    lines = physical_line.rstrip("\n").split("\n")
AttributeError: 'int' object has no attribute 'rstrip'
Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 486, in run_ast_checks
    ast = self.processor.build_ast()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/processor.py", line 212, in build_ast
    return compile("".join(self.lines), "", "exec", PyCF_ONLY_AST)
  File "", line 27
    df2.<TAB>  # noqa: E225, E999
        ^
SyntaxError: invalid syntax

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/bin/flake8-rst", line 8, in <module>
    sys.exit(main())
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8_rst/cli.py", line 16, in main
    app.run(argv)
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 488, in run_ast_checks
    row, column = self._extract_syntax_information(e)
  File "/home/runner/.cache/pre-commit/repomntviav0/py_env-python3/lib/python3.10/site-packages/flake8/checker.py", line 473, in _extract_syntax_information
    lines = physical_line.rstrip("\n").split("\n")
AttributeError: 'int' object has no attribute 'rstrip'

Unwanted patterns.......................................................................................Passed
Check Cython casting is `<type>obj`, not `<type> obj`...................................................Passed
Check for backticks incorrectly rendering because of missing spaces.....................................Passed
Check for unnecessary random seeds in asv benchmarks....................................................Passed
Check for usage of numpy testing or array_equal.........................................................Passed
Check for invalid EA testing............................................................................Passed
Generate pip dependency from conda......................................................................Passed
Check flake8 version is synced across flake8, yesqa, and environment.yml................................Passed
Validate correct capitalization among titles in documentation...........................................Passed
Import pandas.array as pd_array in core.................................................................Passed
Use pandas.io.common.urlopen instead of urllib.request.urlopen..........................................Passed
Use bool_t instead of bool in pandas/core/generic.py....................................................Passed
Use raise instead of return for exceptions..............................................................Passed
Ensure pandas errors are documented in doc/source/reference/testing.rst.................................Passed
Check for pg8000 not installed on CI for test_pg8000_sqlalchemy_passthrough_error.......................Passed
Check minimum version of dependencies are aligned.......................................................Passed
Validate errors locations...............................................................................Passed
flake8-pyi..............................................................................................Passed
import annotations from __future__......................................................................Passed
check that test names start with 'test'.................................................................Passed

Changed files

Changed file:
  • .pre-commit-config.yaml

:octocat: Repo | 📝 Issues | 🏬 Marketplace

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Jan 1, 2023
@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Jan 1, 2023
MarcoGorelli
MarcoGorelli approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved a couple of strings around so they get recognised as docstrings, if there's no objections I'll merge

@mroeschke mroeschke merged commit 9a5702c into main Jan 3, 2023
@mroeschke mroeschke deleted the create-pr-action/pre-commit-config-update-0 branch January 3, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @MarcoGorelli